diff options
| author | Ahmad Fatoum <a.fatoum@pengutronix.de> | 2024-03-04 19:58:55 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2024-03-05 16:28:05 +0100 |
| commit | fdd7da1169dc8e9f8f2c9022926e156ae59631b6 (patch) | |
| tree | b1e8a7f29a6af358c7ca498be201ce8e61226392 /drivers/of | |
| parent | b917445432d5fef789b1ea6c9a1d953f3034a12d (diff) | |
| download | barebox-fdd7da1169dc8e9f8f2c9022926e156ae59631b6.tar.gz barebox-fdd7da1169dc8e9f8f2c9022926e156ae59631b6.tar.xz | |
of: don't report failure to of_read_file twice
of_read_file already prints to log messages when it fails, so
duplicating the error message in the caller is needlessly verbose.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://lore.barebox.org/20240304190038.3486881-11-a.fatoum@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/overlay.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 2d2367fc10..73c7a91db9 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -315,10 +315,8 @@ int of_overlay_apply_file(struct device_node *root, const char *filename, return 0; ovl = of_read_file(filename); - if (IS_ERR(ovl)) { - pr_err("Failed to unflatten %s: %pe\n", filename, ovl); + if (IS_ERR(ovl)) return PTR_ERR(ovl); - } if (filter && !of_overlay_matches_filter(NULL, ovl)) return 0; |