diff options
author | Andrey Smirnov <andrew.smirnov@gmail.com> | 2018-04-12 14:33:16 -0700 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2018-04-17 09:21:10 +0200 |
commit | 25cb29b1357d5005de3e149744a2ebee03a743bf (patch) | |
tree | db754edac03a4e761dc71fa95eff319117515a40 /drivers/serial/stm-serial.c | |
parent | cebb36c9337691754a8d60d60da9731766cf19d2 (diff) | |
download | barebox-25cb29b1357d5005de3e149744a2ebee03a743bf.tar.gz barebox-25cb29b1357d5005de3e149744a2ebee03a743bf.tar.xz |
serial: Drop .remove functions from all drivers
Depending on specifics, some 'serdev' devices might need prevent
parent console device from being removed and corresponding memory
deallocated to properly function until the very end of Barebox's
execution. An example of such a use-case would be a reset handler
relying on a serdev device for transport.
To avoid having to develop complicatione reference counting/ownership
scheme drop all of the code that calls console_unregister() and frees
the memory effectively making the problem above impossible to arise.
All of the de-initialization that serial drivers were doing in their
.remove functions was somewhat superflous anyway, so this change
should be pretty harmless.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/serial/stm-serial.c')
-rw-r--r-- | drivers/serial/stm-serial.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c index 83328f4550..ea482415ce 100644 --- a/drivers/serial/stm-serial.c +++ b/drivers/serial/stm-serial.c @@ -182,15 +182,6 @@ static int stm_serial_probe(struct device_d *dev) return 0; } -static void stm_serial_remove(struct device_d *dev) -{ - struct stm_priv *priv = dev->priv; - - stm_serial_flush(&priv->cdev); - console_unregister(&priv->cdev); - free(priv); -} - static __maybe_unused struct of_device_id stm_serial_dt_ids[] = { { .compatible = "arm,pl011", @@ -202,7 +193,6 @@ static __maybe_unused struct of_device_id stm_serial_dt_ids[] = { static struct driver_d stm_serial_driver = { .name = "stm_serial", .probe = stm_serial_probe, - .remove = stm_serial_remove, .of_compatible = DRV_OF_COMPAT(stm_serial_dt_ids), }; console_platform_driver(stm_serial_driver); |