diff options
| author | Ahmad Fatoum <a.fatoum@pengutronix.de> | 2020-10-07 11:50:55 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2020-10-09 08:48:02 +0200 |
| commit | 63d7846084a20f21a5faa2baf7dcddcbbdab3dfb (patch) | |
| tree | 90473101a705906b7ea67683206bed5a09291521 /drivers | |
| parent | 4229b5848b76ec53c523f4c0a2ad19afd07b16de (diff) | |
| download | barebox-63d7846084a20f21a5faa2baf7dcddcbbdab3dfb.tar.gz barebox-63d7846084a20f21a5faa2baf7dcddcbbdab3dfb.tar.xz | |
aiodev: lm75: fix out-of-bounds write on 64-bit SoCs
Probing the lm75 device driver on 64 bit systems invokes
undefined behavior, because of an errant cast. Fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/aiodev/lm75.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/aiodev/lm75.c b/drivers/aiodev/lm75.c index 8186fd2c2b..8e5948f468 100644 --- a/drivers/aiodev/lm75.c +++ b/drivers/aiodev/lm75.c @@ -22,6 +22,7 @@ #define LM75_SHUTDOWN 0x01 enum lm75_type { /* keep sorted in alphabetical order */ + unknown, adt75, ds1775, ds75, @@ -109,9 +110,9 @@ static int lm75_probe(struct device_d *dev) int new, ret; enum lm75_type kind; - ret = dev_get_drvdata(dev, (const void **)&kind); - if (ret) - return ret; + kind = (enum lm75_type)device_get_match_data(dev); + if (kind == unknown) + return -ENODEV; data = xzalloc(sizeof(*data)); |