diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-09-14 11:00:17 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2021-10-05 13:51:11 +0200 |
| commit | 906f602b7c8a0fa2ff6e405fa391f85be512ece1 (patch) | |
| tree | 7d05c4aee483b09244ee6bd98731f96ebb6095f6 /drivers | |
| parent | 87ed07a0022f0bc202be38abf4a748b5b12edf9a (diff) | |
| download | barebox-906f602b7c8a0fa2ff6e405fa391f85be512ece1.tar.gz barebox-906f602b7c8a0fa2ff6e405fa391f85be512ece1.tar.xz | |
mci: Improve error message for non-existent vmmc regulator
There are three improvements: a) Use a already initialized device as first
parameter to dev_err() and b) indicate that the error will be ignored, and
c) downgrade to a warning.
This changes the error message from
ERROR: <NULL>: Failed to get 'vmmc' regulator.
to
WARNING: bcm2835_mci fe340000.mmc@7e340000.of: Failed to get 'vmmc' regulator (ignored).
on a Raspberry Pi 4.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Link: https://lore.barebox.org/20210914090017.39627-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mci/mci-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c index 92a73c8f1d..82e2f82f53 100644 --- a/drivers/mci/mci-core.c +++ b/drivers/mci/mci-core.c @@ -1920,7 +1920,7 @@ int mci_register(struct mci_host *host) host->supply = regulator_get(hw_dev, "vmmc"); if (IS_ERR(host->supply)) { - dev_err(&mci->dev, "Failed to get 'vmmc' regulator.\n"); + dev_warn(hw_dev, "Failed to get 'vmmc' regulator (ignored).\n"); host->supply = NULL; } |