diff options
| author | Lucas Stach <l.stach@pengutronix.de> | 2020-05-11 18:49:56 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2020-05-12 09:47:37 +0200 |
| commit | f27f4b817737c5c3c0fe33ac629fd6aff765b1cb (patch) | |
| tree | e63904a104141809df9cd4b382c355646c654725 /drivers | |
| parent | fac48fb1309552765c8f0251fe9bbc57f039adc6 (diff) | |
| download | barebox-f27f4b817737c5c3c0fe33ac629fd6aff765b1cb.tar.gz barebox-f27f4b817737c5c3c0fe33ac629fd6aff765b1cb.tar.xz | |
mci: stm32_sdmmc2: don't retry commands
No other MCI does retry failing commands on its own (if at all
this should be done by the MCI core). Remove the retry, as we
don't want to paper over board level issues.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mci/stm32_sdmmc2.c | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c index 0c26869b03..de96f09744 100644 --- a/drivers/mci/stm32_sdmmc2.c +++ b/drivers/mci/stm32_sdmmc2.c @@ -481,11 +481,8 @@ static int stm32_sdmmc2_send_cmd(struct mci_host *mci, struct mci_cmd *cmd, { struct stm32_sdmmc2_priv *priv = to_mci_host(mci); u32 cmdat = data ? SDMMC_CMD_CMDTRANS : 0; - u32 data_length; - int ret, retry = 3; - -retry_cmd: - data_length = 0; + u32 data_length = 0; + int ret; if (data) { data_length = data->blocks * data->blocksize; @@ -530,15 +527,6 @@ retry_cmd: writel(SDMMC_ICR_STATIC_FLAGS, priv->base + SDMMC_ICR); } - if (ret && retry) { - dev_warn(priv->dev, "%s: cmd %d failed, retrying ...\n", - __func__, cmd->cmdidx); - - retry--; - - goto retry_cmd; - } - dev_dbg(priv->dev, "%s: end for CMD %d, ret = %d\n", __func__, cmd->cmdidx, ret); |