diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2014-07-24 12:21:03 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2014-10-08 16:33:34 +0200 |
| commit | ade058360233b8a701c66db282a21502e3a27f79 (patch) | |
| tree | 46a9b7773fbf8eed6268ee8594a6a80ed1ca461d /lib/parameter.c | |
| parent | d096cafff7a83c6b946f350ef441918a65f9933d (diff) | |
| download | barebox-ade058360233b8a701c66db282a21502e3a27f79.tar.gz barebox-ade058360233b8a701c66db282a21502e3a27f79.tar.xz | |
param: let dev_add_param return the newly created param
dev_add_param creates a new parameter so it makes more sense to
return it than to return an error code. Since the return value
is hardly ever checked this is only a small patch.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'lib/parameter.c')
| -rw-r--r-- | lib/parameter.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/parameter.c b/lib/parameter.c index 84a632c34f..d6f8d16a09 100644 --- a/lib/parameter.c +++ b/lib/parameter.c @@ -160,7 +160,7 @@ static int __dev_add_param(struct param_d *param, struct device_d *dev, const ch * expect the parameter value to be a string which can be freed with free(). Do * not use static arrays when using the generic functions. */ -int dev_add_param(struct device_d *dev, const char *name, +struct param_d *dev_add_param(struct device_d *dev, const char *name, int (*set)(struct device_d *dev, struct param_d *p, const char *val), const char *(*get)(struct device_d *dev, struct param_d *param), unsigned long flags) @@ -171,10 +171,12 @@ int dev_add_param(struct device_d *dev, const char *name, param = xzalloc(sizeof(*param)); ret = __dev_add_param(param, dev, name, set, get, flags); - if (ret) + if (ret) { free(param); + return ERR_PTR(ret); + } - return ret; + return param; } /** |