summaryrefslogtreecommitdiffstats
path: root/net/eth.c
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2024-02-02 16:11:47 +0100
committerSascha Hauer <s.hauer@pengutronix.de>2024-02-05 08:47:09 +0100
commit96a5f863fbda1833d53aaef45abbb0960586b5ef (patch)
tree654dbac9e4a8bc0aa57a59b1f693216a0527a959 /net/eth.c
parent107eeef8f2a95142e2118bf4783cecc82778814a (diff)
downloadbarebox-96a5f863fbda1833d53aaef45abbb0960586b5ef.tar.gz
barebox-96a5f863fbda1833d53aaef45abbb0960586b5ef.tar.xz
eth: replace ethaddr_to_string() with %pM
Now that we can print MAC addresses using the %pM format specifier we can get rid of ethaddr_to_string(). Do this treewide. Link: https://lore.barebox.org/20240202151147.226876-2-s.hauer@pengutronix.de Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'net/eth.c')
-rw-r--r--net/eth.c13
1 files changed, 5 insertions, 8 deletions
diff --git a/net/eth.c b/net/eth.c
index d1474ec57d..28961e868b 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -55,11 +55,8 @@ int eth_set_ethaddr(struct eth_device *edev, const char *ethaddr)
static void register_preset_mac_address(struct eth_device *edev, const char *ethaddr)
{
- unsigned char ethaddr_str[sizeof("xx:xx:xx:xx:xx:xx")];
-
if (is_valid_ether_addr(ethaddr)) {
- ethaddr_to_string(ethaddr, ethaddr_str);
- dev_info(&edev->dev, "got preset MAC address: %s\n", ethaddr_str);
+ dev_info(&edev->dev, "got preset MAC address: %pM\n", ethaddr);
eth_set_ethaddr(edev, ethaddr);
}
}
@@ -557,7 +554,6 @@ void eth_open_all(void)
static int populate_ethaddr(void)
{
- char str[sizeof("xx:xx:xx:xx:xx:xx")];
struct eth_device *edev;
bool generated = false;
int ret;
@@ -575,11 +571,12 @@ static int populate_ethaddr(void)
if (ret)
continue;
- ethaddr_to_string(edev->ethaddr, str);
if (generated)
- dev_notice(&edev->dev, "Generated MAC address from unique id: %s\n", str);
+ dev_notice(&edev->dev, "Generated MAC address from unique id: %pM\n",
+ edev->ethaddr);
else
- dev_info(&edev->dev, "Got preset MAC address from NVMEM: %s\n", str);
+ dev_info(&edev->dev, "Got preset MAC address from NVMEM: %pM\n",
+ edev->ethaddr);
eth_set_ethaddr(edev, edev->ethaddr);
}