diff options
| author | Javier González <jg@lightnvm.io> | 2017-05-03 11:19:04 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2017-05-04 07:53:04 -0600 |
| commit | 2e13f33a2464fc3aa7783022a90309cabeca8935 (patch) | |
| tree | db025603a0572b86538f0e15a1d131cfb5d8e268 | |
| parent | 2719aa217e0d025dbfce74ac777815776ccec072 (diff) | |
| download | linux-0-day-2e13f33a2464fc3aa7783022a90309cabeca8935.tar.gz linux-0-day-2e13f33a2464fc3aa7783022a90309cabeca8935.tar.xz | |
lightnvm: create cmd before allocating request
Create nvme command before allocating a request using
nvme_alloc_request, which uses the command direction. Up until now, the
command has been zeroized, so all commands have been allocated as a
read operation.
Signed-off-by: Javier González <javier@cnexlabs.com>
Reviewed-by: Matias Bjørling <matias@cnexlabs.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | drivers/nvme/host/lightnvm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index e4e4e60b1224f..8c4adac6fafcc 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -503,6 +503,8 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd) if (!cmd) return -ENOMEM; + nvme_nvm_rqtocmd(rq, rqd, ns, cmd); + rq = nvme_alloc_request(q, (struct nvme_command *)cmd, 0, NVME_QID_ANY); if (IS_ERR(rq)) { kfree(cmd); @@ -517,8 +519,6 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd) rq->__data_len = 0; } - nvme_nvm_rqtocmd(rq, rqd, ns, cmd); - rq->end_io_data = rqd; blk_execute_rq_nowait(q, NULL, rq, 0, nvme_nvm_end_io); |