diff options
| author | Arkadi Sharshevsky <arkadis@mellanox.com> | 2017-01-12 09:10:37 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-12 09:25:55 -0500 |
| commit | 36bf38d158d3482119b3e159c0619b3c1539b508 (patch) | |
| tree | 050d254d2269e55c9cd2744cda8852bb2c56de72 | |
| parent | 0719e72ccb801829a3d735d187ca8417f0930459 (diff) | |
| download | linux-0-day-36bf38d158d3482119b3e159c0619b3c1539b508.tar.gz linux-0-day-36bf38d158d3482119b3e159c0619b3c1539b508.tar.xz | |
mlxsw: spectrum: Fix memory leak at skb reallocation
During transmission the skb is checked for headroom in order to
add vendor specific header. In case the skb needs to be re-allocated,
skb_realloc_headroom() is called to make a private copy of the original,
but doesn't release it. Current code assumes that the original skb is
released during reallocation and only releases it at the error path
which causes a memory leak.
Fix this by adding the original skb release to the main path.
Fixes: 56ade8fe3fe1 ("mlxsw: spectrum: Add initial support for Spectrum ASIC")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index d768c7b6c6d66..003093abb1707 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -684,6 +684,7 @@ static netdev_tx_t mlxsw_sp_port_xmit(struct sk_buff *skb, dev_kfree_skb_any(skb_orig); return NETDEV_TX_OK; } + dev_consume_skb_any(skb_orig); } if (eth_skb_pad(skb)) { |