diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-10-04 09:33:52 +0200 |
|---|---|---|
| committer | Krzysztof Kozlowski <krzk@kernel.org> | 2017-10-04 21:09:19 +0200 |
| commit | a3d1d8a77c2e7fee3dabc328955d04ec7a9d14ec (patch) | |
| tree | 181094cb1a22fe4ac632b78729dfa2a0ee57c93f /arch/arm/plat-samsung | |
| parent | 0640357bf4f9a8b8c624c295bd0e001e5d0db5a9 (diff) | |
| download | linux-0-day-a3d1d8a77c2e7fee3dabc328955d04ec7a9d14ec.tar.gz linux-0-day-a3d1d8a77c2e7fee3dabc328955d04ec7a9d14ec.tar.xz | |
ARM: SAMSUNG: Remove printk for failed memory allocation
Omit an extra message for a memory allocation failure in adc.c and
platformdata.c.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Diffstat (limited to 'arch/arm/plat-samsung')
| -rw-r--r-- | arch/arm/plat-samsung/adc.c | 8 | ||||
| -rw-r--r-- | arch/arm/plat-samsung/platformdata.c | 4 |
2 files changed, 3 insertions, 9 deletions
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c index daf3db9f0058f..f8d6206e4daa1 100644 --- a/arch/arm/plat-samsung/adc.c +++ b/arch/arm/plat-samsung/adc.c @@ -239,10 +239,8 @@ struct s3c_adc_client *s3c_adc_register(struct platform_device *pdev, return ERR_PTR(-EINVAL); client = kzalloc(sizeof(struct s3c_adc_client), GFP_KERNEL); - if (!client) { - dev_err(&pdev->dev, "no memory for adc client\n"); + if (!client) return ERR_PTR(-ENOMEM); - } client->pdev = pdev; client->is_ts = is_ts; @@ -345,10 +343,8 @@ static int s3c_adc_probe(struct platform_device *pdev) unsigned tmp; adc = devm_kzalloc(dev, sizeof(struct adc_device), GFP_KERNEL); - if (adc == NULL) { - dev_err(dev, "failed to allocate adc_device\n"); + if (!adc) return -ENOMEM; - } spin_lock_init(&adc->lock); diff --git a/arch/arm/plat-samsung/platformdata.c b/arch/arm/plat-samsung/platformdata.c index b430e9946287e..6cf52ee7eeece 100644 --- a/arch/arm/plat-samsung/platformdata.c +++ b/arch/arm/plat-samsung/platformdata.c @@ -29,10 +29,8 @@ void __init *s3c_set_platdata(void *pd, size_t pdsize, } npd = kmemdup(pd, pdsize, GFP_KERNEL); - if (!npd) { - printk(KERN_ERR "%s: cannot clone platform data\n", pdev->name); + if (!npd) return NULL; - } pdev->dev.platform_data = npd; return npd; |