diff options
| author | Ming Lei <ming.lei@canonical.com> | 2015-08-09 03:41:50 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-08-15 09:45:19 -0600 |
| commit | 596f5aad2a704b72934e5abec1b1b4114c16f45b (patch) | |
| tree | 023d281a8921d55c79050e35117d4a67df53a485 /block/blk-mq-tag.h | |
| parent | 2ec3182f9c20a9eef0dacc0512cf2ca2df7be5ad (diff) | |
| download | linux-0-day-596f5aad2a704b72934e5abec1b1b4114c16f45b.tar.gz linux-0-day-596f5aad2a704b72934e5abec1b1b4114c16f45b.tar.xz | |
blk-mq: fix buffer overflow when reading sysfs file of 'pending'
There may be lots of pending requests so that the buffer of PAGE_SIZE
can't hold them at all.
One typical example is scsi-mq, the queue depth(.can_queue) of
scsi_host and blk-mq is quite big but scsi_device's queue_depth
is a bit small(.cmd_per_lun), then it is quite easy to have lots
of pending requests in hw queue.
This patch fixes the following warning and the related memory
destruction.
[ 359.025101] fill_read_buffer: blk_mq_hw_sysfs_show+0x0/0x7d returned bad count^M
[ 359.055595] irq event stamp: 15537^M
[ 359.055606] general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC ^M
[ 359.055614] Dumping ftrace buffer:^M
[ 359.055660] (ftrace buffer empty)^M
[ 359.055672] Modules linked in: nbd ipv6 kvm_intel kvm serio_raw^M
[ 359.055678] CPU: 4 PID: 21631 Comm: stress-ng-sysfs Not tainted 4.2.0-rc5-next-20150805 #434^M
[ 359.055679] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011^M
[ 359.055682] task: ffff8802161cc000 ti: ffff88021b4a8000 task.ti: ffff88021b4a8000^M
[ 359.055693] RIP: 0010:[<ffffffff811541c5>] [<ffffffff811541c5>] __kmalloc+0xe8/0x152^M
Cc: <stable@vger.kernel.org>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-mq-tag.h')
0 files changed, 0 insertions, 0 deletions