diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2016-04-20 20:33:05 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2016-04-25 11:30:57 +0200 |
| commit | bbf4ac9cfa9b681e3b657699f39fc855408904b8 (patch) | |
| tree | 2f1cdedea7b23f5b10a3496cd2762fc9124c9ccb /drivers/hid | |
| parent | a4362fd6da7ab8b08028734004df486847ea593e (diff) | |
| download | linux-0-day-bbf4ac9cfa9b681e3b657699f39fc855408904b8.tar.gz linux-0-day-bbf4ac9cfa9b681e3b657699f39fc855408904b8.tar.xz | |
HID: thingm: remove not needed error message
LED core takes care of handling failed calls to thingm_let_set.
- print error message in set_brightness_delayed or
- pass error to caller in led_set_brightness_sync
Also the error message here doesn't provide any hint what actually
went wrong. Therefore remove it.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@rehat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-thingm.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/hid/hid-thingm.c b/drivers/hid/hid-thingm.c index 2507bbe0eea7f..9ad9c6ec5bba2 100644 --- a/drivers/hid/hid-thingm.c +++ b/drivers/hid/hid-thingm.c @@ -148,13 +148,8 @@ static int thingm_led_set(struct led_classdev *ldev, enum led_brightness brightness) { struct thingm_led *led = container_of(ldev, struct thingm_led, ldev); - int ret; - - ret = thingm_write_color(led->rgb); - if (ret) - hid_err(led->rgb->tdev->hdev, "failed to write color\n"); - return ret; + return thingm_write_color(led->rgb); } static int thingm_init_led(struct thingm_led *led, const char *color_name, |