diff options
| author | Arvind Yadav <arvind.yadav.cs@gmail.com> | 2017-11-16 09:57:27 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-11-16 22:31:16 +0900 |
| commit | 4bef0eb020943a7fcd031265f68d504214868de2 (patch) | |
| tree | a6e1d5b71db2c4409efe5357cb5d991fcce5b29f /drivers/isdn | |
| parent | 203d2027a1e95e7d9585d734bdeaac6057058357 (diff) | |
| download | linux-0-day-4bef0eb020943a7fcd031265f68d504214868de2.tar.gz linux-0-day-4bef0eb020943a7fcd031265f68d504214868de2.tar.xz | |
isdn: hisax: Fix pnp_irq's error checking for setup_niccy
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/hisax/niccy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hisax/niccy.c b/drivers/isdn/hisax/niccy.c index e4c33cfe3ef48..dfbcd2eaa81a3 100644 --- a/drivers/isdn/hisax/niccy.c +++ b/drivers/isdn/hisax/niccy.c @@ -261,7 +261,7 @@ int setup_niccy(struct IsdnCard *card) card->para[1] = pnp_port_start(pnp_d, 0); card->para[2] = pnp_port_start(pnp_d, 1); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1] || + if (card->para[0] == -1 || !card->para[1] || !card->para[2]) { printk(KERN_ERR "NiccyPnP:some resources are " "missing %ld/%lx/%lx\n", |