diff options
| author | Daniel Wagner <daniel.wagner@bmw-carit.de> | 2016-04-15 10:22:27 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-05-01 14:20:04 -0700 |
| commit | 8d026465ecf68823c633f7b60d39a8a17dd3bc27 (patch) | |
| tree | 7363bcefc3acada723eda0f62d90fb7cf9adebda /drivers/misc/ti-st | |
| parent | 66b58edf592fd7a6fc0f106e0809e52b52d4722f (diff) | |
| download | linux-0-day-8d026465ecf68823c633f7b60d39a8a17dd3bc27.tar.gz linux-0-day-8d026465ecf68823c633f7b60d39a8a17dd3bc27.tar.xz | |
ti-st: Fix complete_all() wrong usage
complete_all() should only be called once, doing it twice is a clear bug.
8565adbc8214 ("drivers/misc/ti-st: fix read fw version cmd") added the
additional complete_all() call. Since we call complete_all() when
leaving the function we can drop the complete_all() call inside
true branch of the if statement.
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Pavan Savoy <pavan_savoy@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/ti-st')
| -rw-r--r-- | drivers/misc/ti-st/st_kim.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index 71b64550b5918..bf0d7708beac5 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -78,7 +78,6 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata) memcpy(kim_gdata->resp_buffer, kim_gdata->rx_skb->data, kim_gdata->rx_skb->len); - complete_all(&kim_gdata->kim_rcvd); kim_gdata->rx_state = ST_W4_PACKET_TYPE; kim_gdata->rx_skb = NULL; kim_gdata->rx_count = 0; |