summaryrefslogtreecommitdiffstats
path: root/drivers/platform/x86/Kconfig
diff options
context:
space:
mode:
authorRandy Dunlap <rdunlap@infradead.org>2018-01-14 21:11:18 -0800
committerDarren Hart (VMware) <dvhart@infradead.org>2018-01-15 12:52:07 -0800
commit4f258cf4012e24b92b0db7b7b7a8ee883e13782b (patch)
tree774899f73891b556c9346c373c565258fe3df628 /drivers/platform/x86/Kconfig
parent28d71ae92182334421d642297f3b2bf642526c12 (diff)
downloadlinux-0-day-4f258cf4012e24b92b0db7b7b7a8ee883e13782b.tar.gz
linux-0-day-4f258cf4012e24b92b0db7b7b7a8ee883e13782b.tar.xz
platform/x86: have ACPI_CMPC use depends instead of select for INPUT
Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. This also makes all platform/x86/ drivers consistent w.r.t depending on INPUT instead of selecting it. Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Andy Shevchenko <andy@infradead.org> Cc: platform-driver-x86@vger.kernel.org Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
Diffstat (limited to 'drivers/platform/x86/Kconfig')
-rw-r--r--drivers/platform/x86/Kconfig3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 8a07df54a67e8..de51952f0a927 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -838,9 +838,8 @@ config TOSHIBA_WMI
config ACPI_CMPC
tristate "CMPC Laptop Extras"
- depends on ACPI
+ depends on ACPI && INPUT
depends on RFKILL || RFKILL=n
- select INPUT
select BACKLIGHT_CLASS_DEVICE
help
Support for Intel Classmate PC ACPI devices, including some