diff options
| author | Sinan Kaya <okaya@codeaurora.org> | 2016-07-19 09:01:49 -0400 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2016-07-19 10:54:45 -0600 |
| commit | 0991bbdbf5b85bd14a26e783f087b0f2913c93b1 (patch) | |
| tree | dd30472250b3624da8d809f58fbe309d496f8ac5 /drivers/vfio | |
| parent | e99442323f33470677deeed35619313b05837f35 (diff) | |
| download | linux-0-day-0991bbdbf5b85bd14a26e783f087b0f2913c93b1.tar.gz linux-0-day-0991bbdbf5b85bd14a26e783f087b0f2913c93b1.tar.xz | |
vfio: platform: check reset call return code during release
Release call is ignoring the return code from reset call and can
potentially continue even though reset call failed.
If reset_required module parameter is set, this patch is going
to validate the return code and will cause stack dump with
WARN_ON and warn the user of failure.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
| -rw-r--r-- | drivers/vfio/platform/vfio_platform_common.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c index 389d6515bc09a..1cf2d462b53de 100644 --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -230,7 +230,15 @@ static void vfio_platform_release(void *device_data) mutex_lock(&driver_lock); if (!(--vdev->refcnt)) { - vfio_platform_call_reset(vdev, NULL); + const char *extra_dbg = NULL; + int ret; + + ret = vfio_platform_call_reset(vdev, &extra_dbg); + if (ret && vdev->reset_required) { + dev_warn(vdev->device, "reset driver is required and reset call failed in release (%d) %s\n", + ret, extra_dbg ? extra_dbg : ""); + WARN_ON(1); + } vfio_platform_regions_cleanup(vdev); vfio_platform_irq_cleanup(vdev); } |