diff options
| author | Steve French <sfrench@us.ibm.com> | 2010-02-08 17:39:58 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2010-02-08 17:39:58 +0000 |
| commit | ccd4bb1beb3316de4611de24d223ad761b5a7e95 (patch) | |
| tree | 9b61040312a7ef2012e27bd0db2a614fd6e3a68c /fs/cifs | |
| parent | 301a6a317797ca362951ea21da397c05236f0070 (diff) | |
| download | linux-0-day-ccd4bb1beb3316de4611de24d223ad761b5a7e95.tar.gz linux-0-day-ccd4bb1beb3316de4611de24d223ad761b5a7e95.tar.xz | |
[CIFS] Don't cache timestamps on utimes due to coarse granularity
force revalidate of the file when any of the timestamps are set since
some filesytem types do not have finer granularity timestamps and
we can not always detect which file systems round timestamps down
to determine whether we can cache the mtime on setattr
samba bugzilla 3775
Acked-by: Shirish Pargaonkar <sharishp@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/inode.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index cf18ee7655902..e3fda978f4816 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -1762,8 +1762,18 @@ cifs_setattr_unix(struct dentry *direntry, struct iattr *attrs) CIFS_MOUNT_MAP_SPECIAL_CHR); } - if (!rc) + if (!rc) { rc = inode_setattr(inode, attrs); + + /* force revalidate when any of these times are set since some + of the fs types (eg ext3, fat) do not have fine enough + time granularity to match protocol, and we do not have a + a way (yet) to query the server fs's time granularity (and + whether it rounds times down). + */ + if (!rc && (attrs->ia_valid & (ATTR_MTIME | ATTR_CTIME))) + cifsInode->time = 0; + } out: kfree(args); kfree(full_path); |