diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-05-23 13:21:01 +0300 |
|---|---|---|
| committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2016-05-25 12:11:58 -0400 |
| commit | 2997bfd0492d33d230b1475909a0211157a734bc (patch) | |
| tree | 0e7ed809bc6feae676421b3e2fa81e3b65a40ffd /fs/nfs | |
| parent | 1b3c6d07e29515064aca8a9f86efaea7da4da027 (diff) | |
| download | linux-0-day-2997bfd0492d33d230b1475909a0211157a734bc.tar.gz linux-0-day-2997bfd0492d33d230b1475909a0211157a734bc.tar.xz | |
NFS: checking for NULL instead of IS_ERR() in nfs_commit_file()
nfs_create_request() doesn't return NULL, it returns error pointers.
Fixes: 67911c8f18b5 ('NFS: Add nfs_commit_file()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/write.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 4dac51ba1f7ea..54a4eb6bc4629 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -1735,8 +1735,8 @@ int nfs_commit_file(struct file *file, struct nfs_write_verifier *verf) open = get_nfs_open_context(nfs_file_open_context(file)); req = nfs_create_request(open, NULL, NULL, 0, i_size_read(inode)); - if (!req) { - ret = -ENOMEM; + if (IS_ERR(req)) { + ret = PTR_ERR(req); goto out_put; } |