diff options
| author | Zefan Li <lizefan@huawei.com> | 2014-09-19 16:51:00 +0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2014-09-19 09:29:32 -0400 |
| commit | a25eb52e81a40e986179a790fbb5a1f02f482b7a (patch) | |
| tree | 1d88c2bfdd17f168a5c21b4038d697148187d958 /include/linux/cgroup.h | |
| parent | 4e2ba65068ac1d0e8c9df78a4ad787cf39640418 (diff) | |
| download | linux-0-day-a25eb52e81a40e986179a790fbb5a1f02f482b7a.tar.gz linux-0-day-a25eb52e81a40e986179a790fbb5a1f02f482b7a.tar.xz | |
cgroup: remove CGRP_RELEASABLE flag
We call put_css_set() after setting CGRP_RELEASABLE flag in
cgroup_task_migrate(), but in other places we call it without setting
the flag. I don't see the necessity of this flag.
Moreover once the flag is set, it will never be cleared, unless writing
to the notify_on_release control file, so it can be quite confusing
if we look at the output of debug.releasable.
# mount -t cgroup -o debug xxx /cgroup
# mkdir /cgroup/child
# cat /cgroup/child/debug.releasable
0 <-- shows 0 though the cgroup is empty
# echo $$ > /cgroup/child/tasks
# cat /cgroup/child/debug.releasable
0
# echo $$ > /cgroup/tasks && echo $$ > /cgroup/child/tasks
# cat /proc/child/debug.releasable
1 <-- shows 1 though the cgroup is not empty
This patch removes the flag, and now debug.releasable shows if the
cgroup is empty or not.
Signed-off-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'include/linux/cgroup.h')
| -rw-r--r-- | include/linux/cgroup.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 818a81fe7ccc3..1d51968890480 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -161,11 +161,6 @@ static inline void css_put(struct cgroup_subsys_state *css) /* bits in struct cgroup flags field */ enum { - /* - * Control Group has previously had a child cgroup or a task, - * but no longer (only if CGRP_NOTIFY_ON_RELEASE is set) - */ - CGRP_RELEASABLE, /* Control Group requires release notifications to userspace */ CGRP_NOTIFY_ON_RELEASE, /* |