diff options
| author | Jan Kara <jack@suse.cz> | 2011-12-22 14:52:21 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2012-01-09 13:52:09 +0100 |
| commit | 0048278552e9752fd578c3d8deee756987c10873 (patch) | |
| tree | 0931a7ff6aa5c388eb40e2a97fdcebe59bbae337 /include/linux/jbd.h | |
| parent | a9e36da655e54545c3289b2a0700b5c443de0edd (diff) | |
| download | linux-0-day-0048278552e9752fd578c3d8deee756987c10873.tar.gz linux-0-day-0048278552e9752fd578c3d8deee756987c10873.tar.xz | |
jbd: Remove j_barrier mutex
j_barrier mutex is used for serializing different journal lock operations. The
problem with it is that e.g. FIFREEZE ioctl results in process leaving kernel
with j_barrier mutex held which makes lockdep freak out. Also hibernation code
wants to freeze filesystem but it cannot do so because it then cannot hibernate
the system because of mutex being locked.
So we remove j_barrier mutex and use direct wait on j_barrier_count instead.
Since locking journal is a rare operation we don't have to care about fairness
or such things.
CC: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'include/linux/jbd.h')
| -rw-r--r-- | include/linux/jbd.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/include/linux/jbd.h b/include/linux/jbd.h index 492cc12244fdf..d211732b9e99c 100644 --- a/include/linux/jbd.h +++ b/include/linux/jbd.h @@ -497,7 +497,6 @@ struct transaction_s * @j_format_version: Version of the superblock format * @j_state_lock: Protect the various scalars in the journal * @j_barrier_count: Number of processes waiting to create a barrier lock - * @j_barrier: The barrier lock itself * @j_running_transaction: The current running transaction.. * @j_committing_transaction: the transaction we are pushing to disk * @j_checkpoint_transactions: a linked circular list of all transactions @@ -580,9 +579,6 @@ struct journal_s */ int j_barrier_count; - /* The barrier lock itself */ - struct mutex j_barrier; - /* * Transactions: The current running transaction... * [j_state_lock] [caller holding open handle] |