diff options
| author | Julia Lawall <julia.lawall@lip6.fr> | 2017-01-17 12:23:21 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-17 14:10:35 -0500 |
| commit | a249708bc2aa1fe3ddf15dfac22bee519d15996b (patch) | |
| tree | 0dc63920466e96fcb3f420dfcf6e35d3bc82bb62 | |
| parent | 501db511397fd6efff3aa5b4e8de415b55559550 (diff) | |
| download | linux-a249708bc2aa1fe3ddf15dfac22bee519d15996b.tar.gz linux-a249708bc2aa1fe3ddf15dfac22bee519d15996b.tar.xz | |
stmmac: add missing of_node_put
The function stmmac_dt_phy provides several possibilities for initializing
plat->mdio_node, all of which have the effect of increasing the reference
count of the assigned value. This field is not updated elsewhere, so the
value is live until the end of the lifetime of plat (devm_allocated), just
after the end of stmmac_remove_config_dt. Thus, add an of_node_put on
plat->mdio_node in stmmac_remove_config_dt. It is possible that the field
mdio_node is never initialized, but of_node_put is NULL-safe, so it is also
safe to call of_node_put in that case.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 082cd48db6a7..36942f5a6a53 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -351,6 +351,7 @@ void stmmac_remove_config_dt(struct platform_device *pdev, if (of_phy_is_fixed_link(np)) of_phy_deregister_fixed_link(np); of_node_put(plat->phy_node); + of_node_put(plat->mdio_node); } #else struct plat_stmmacenet_data * |