summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/sfc/ef10.c
diff options
context:
space:
mode:
authorJon Cooper <jcooper@solarflare.com>2017-01-27 15:02:39 +0000
committerDavid S. Miller <davem@davemloft.net>2017-01-27 11:59:31 -0500
commit34e7aefb2a15f3180635e5730f01f5ce4a0734ec (patch)
tree41721eaf88b5f0745b757699a660bec35392fcb1 /drivers/net/ethernet/sfc/ef10.c
parentf617f27653c4d9f5b2aa43d567ac0405df889944 (diff)
downloadlinux-34e7aefb2a15f3180635e5730f01f5ce4a0734ec.tar.gz
linux-34e7aefb2a15f3180635e5730f01f5ce4a0734ec.tar.xz
sfc: refactor debug-or-warnings printks
Rationalise several debug-or-warnings printks using netif_cond_dbg to make output more consistent. Signed-off-by: Edward Cree <ecree@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/ef10.c')
-rw-r--r--drivers/net/ethernet/sfc/ef10.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index b64b47b4a7f1..d0c1ed0e0354 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -4881,10 +4881,10 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx,
rc = efx_ef10_filter_insert(efx, &spec, true);
if (rc < 0) {
- netif_printk(efx, drv, rc == -EPERM ? KERN_DEBUG : KERN_WARNING,
- efx->net_dev,
- "%scast mismatch filter insert failed rc=%d\n",
- multicast ? "Multi" : "Uni", rc);
+ netif_cond_dbg(efx, drv, efx->net_dev,
+ rc == -EPERM, warn,
+ "%scast mismatch filter insert failed rc=%d\n",
+ multicast ? "Multi" : "Uni", rc);
} else if (multicast) {
EFX_WARN_ON_PARANOID(vlan->mcdef != EFX_EF10_FILTER_ID_INVALID);
vlan->mcdef = efx_ef10_filter_get_unsafe_id(efx, rc);