diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-02-07 10:44:31 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-07 14:00:37 -0500 |
| commit | ee467fbaaf8eed86efc335753bd95971aa444f7a (patch) | |
| tree | 353715f1cf36d1787269cb30437cd094d7b3ddc5 /drivers/net/ethernet/sfc/ef10.c | |
| parent | ac6e058b75be71208e98a5808453aae9a17be480 (diff) | |
| download | linux-ee467fbaaf8eed86efc335753bd95971aa444f7a.tar.gz linux-ee467fbaaf8eed86efc335753bd95971aa444f7a.tar.xz | |
sfc: fix an off by one bug
This bug is harmless because it's just a sanity check and we always
pass valid values for "encap_type" but the test is off by one.
Fixes: 9b4108012517 ("sfc: insert catch-all filters for encapsulated traffic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Bert Kenward <bkenward@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/ef10.c')
| -rw-r--r-- | drivers/net/ethernet/sfc/ef10.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 0475f1831b92..dec0c8083ff3 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -5134,7 +5134,7 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx, /* quick bounds check (BCAST result impossible) */ BUILD_BUG_ON(EFX_EF10_BCAST != 0); - if (encap_type > ARRAY_SIZE(map) || map[encap_type] == 0) { + if (encap_type >= ARRAY_SIZE(map) || map[encap_type] == 0) { WARN_ON(1); return -EINVAL; } |