summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/sfc
diff options
context:
space:
mode:
authorBert Kenward <bkenward@solarflare.com>2017-02-06 16:50:55 +0000
committerDavid S. Miller <davem@davemloft.net>2017-02-06 11:59:36 -0500
commitf820c0ac6cc84d4f9cb22c77d99ea510bd5c382a (patch)
treecc445d4d83b850d5a8860ca2a36bb5138d1f86a0 /drivers/net/ethernet/sfc
parentd15c9ede6123dbce14c17eb9ced229e488002735 (diff)
downloadlinux-f820c0ac6cc84d4f9cb22c77d99ea510bd5c382a.tar.gz
linux-f820c0ac6cc84d4f9cb22c77d99ea510bd5c382a.tar.xz
sfc: don't rearm interrupts if busy polling
Since commit 364b6055738b ("net: busy-poll: return busypolling status to drivers"), napi_complete_done() returns a boolean that can be used by drivers to conditionally rearm interrupts. Testing with a 7142 shows a small latency improvement of ~100 ns. Signed-off-by: Bert Kenward <bkenward@solarflare.com> Cc: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc')
-rw-r--r--drivers/net/ethernet/sfc/efx.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index fcd4eeecfef4..c28cd9daf949 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -328,8 +328,8 @@ static int efx_poll(struct napi_struct *napi, int budget)
* since efx_nic_eventq_read_ack() will have no effect if
* interrupts have already been disabled.
*/
- napi_complete_done(napi, spent);
- efx_nic_eventq_read_ack(channel);
+ if (napi_complete_done(napi, spent))
+ efx_nic_eventq_read_ack(channel);
}
return spent;