diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2017-02-23 14:22:19 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-24 11:42:55 -0500 |
| commit | 65f2767a64ab33847d5f028661b82d8d3a4fda99 (patch) | |
| tree | 1deb5c6af7f632dff00590bdeef147755c9d12ce /drivers/net/phy | |
| parent | 4e37d6911f36545b286d15073f6f2222f840e81c (diff) | |
| download | linux-65f2767a64ab33847d5f028661b82d8d3a4fda99.tar.gz linux-65f2767a64ab33847d5f028661b82d8d3a4fda99.tar.xz | |
net: phy: Add missing driver check in phy_aneg_done()
Dan's static checker caught a potential code path in phy_state_machine() where
we were not checking phydev->drv which is in phy_aneg_done().
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 25149ef9d25c ("net: phy: Check phydev->drv")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/phy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index d6f7838455dd..1be69d8bc909 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -146,7 +146,7 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts) */ int phy_aneg_done(struct phy_device *phydev) { - if (phydev->drv->aneg_done) + if (phydev->drv && phydev->drv->aneg_done) return phydev->drv->aneg_done(phydev); return genphy_aneg_done(phydev); |