diff options
| author | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2015-05-04 18:00:18 +0200 |
|---|---|---|
| committer | Thiago Santos <thiagoss@osg.samsung.com> | 2015-05-05 13:54:08 -0300 |
| commit | 9d85e23c3d960724a551e057cf412989174ee875 (patch) | |
| tree | f1bd09c4ed56a5edae50e59135cefa3005e591f7 /sys | |
| parent | f90bb8140ddbf86e73771946d6c5968b56e0caef (diff) | |
| download | gst-plugins-base-9d85e23c3d960724a551e057cf412989174ee875.tar.gz gst-plugins-base-9d85e23c3d960724a551e057cf412989174ee875.tar.xz | |
xvimagesink: fix navigation event leak when not handled
gst_navigation_message_new_event() is *not* consuming the event so we should
always drop our extra reference.
https://bugzilla.gnome.org/show_bug.cgi?id=748903
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/xvimage/xvimagesink.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c index 38f9de845..611254597 100644 --- a/sys/xvimage/xvimagesink.c +++ b/sys/xvimage/xvimagesink.c @@ -1185,8 +1185,6 @@ gst_xvimagesink_navigation_send_event (GstNavigation * navigation, gst_event_ref (event); handled = gst_pad_send_event (peer, event); - if (handled) - gst_event_unref (event); gst_object_unref (peer); } @@ -1194,6 +1192,9 @@ gst_xvimagesink_navigation_send_event (GstNavigation * navigation, gst_element_post_message ((GstElement *) xvimagesink, gst_navigation_message_new_event ((GstObject *) xvimagesink, event)); } + + if (event) + gst_event_unref (event); } static void |