blob: 06926e58d614c2808ccb3dd874267b725278e004 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
|
#!/bin/bash
#
# Copyright (C) 2013 by Michael Olbrich <m.olbrich@pengutronix.de>
#
# For further information about the PTXdist project and license conditions
# see the README file.
#
export PTXDIST_LINT_COMMANDS
ptxd_lint_error() {
while [ $# -gt 0 ]; do
echo -e "${1}"
shift
done
touch "${PTXDIST_TEMPDIR}/lint-failed"
}
export -f ptxd_lint_error
ptxd_make_world_lint_patches() {
local findfd
echo "Checking patch directories ..."
ptxd_in_path PTXDIST_PATH_PATCHES
exec {findfd}< <(find "${ptxd_reply[@]}" -mindepth 1 -maxdepth 1 -type d)
while read path <&${findfd}; do
if ! [[ " ${ptx_patch_dir_all} " =~ " ${path} " ]]; then
ptxd_lint_error "Unused patch dir '$(ptxd_print_path "${path}")'."
fi
done
exec {findfd}<&-
echo
}
export -f ptxd_make_world_lint_patches
PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} patches"
ptxd_make_world_lint_symbols_make() {
local sedfd
# - drop comments
# - split after ')' to match multiple symbols in one line
# - match '$(PTXCONF_*)'
# - match 'ifdef PTXCONF_*' and similar things
exec {sedfd}< <(sed -e '/^#/d' -e 's/)/)\n/g' "${1}" | \
sed -n -e 's/.*\$(PTXCONF_\([A-Z0-9_]\+\)).*/\1/p' \
-e 's/.* PTXCONF_\([A-Z0-9_]\+\)$/\1/p' | sort -u)
while read symbol <&${sedfd}; do
if ! [[ " ${symbols_all} " =~ " ${symbol} " ]]; then
if [[ "${symbol}" =~ ^(BOARD|)SETUP_ ]]; then
# skip for now because we cannot track those symbols
continue
fi
symbol="PTXCONF_${symbol}"
if [ -z "${!symbol}" ]; then
ptxd_lint_error "Undefined symbol ${symbol} used in '$(ptxd_print_path "${1}")'."
fi
fi
done
exec {sedfd}<&-
}
export -f ptxd_make_world_lint_symbols_make
ptxd_make_world_lint_makefiles() {
ptxd_in_path PTXDIST_PATH_PRERULES
find "${ptxd_reply[@]}" -type f -name "*.make"
while read cmd file; do
if [ "${cmd}" = "include" ]; then
echo "${file}"
fi
done < "${ptx_dgen_rulesfiles_make}"
ptxd_in_path PTXDIST_PATH_POSTRULES
find "${ptxd_reply[@]}" -type f -name "*.make"
}
export -f ptxd_make_world_lint_makefiles
ptxd_make_world_lint_symbols() {
local symbol symbols_all
echo "Checking kconfig symbols in menu files ..."
if [ -e "${PTXDIST_TEMPDIR}/SYMBOLS_UNKNOWN" ]; then
for symbol in $(<${PTXDIST_TEMPDIR}/SYMBOLS_UNKNOWN); do
ptxd_lint_error "Undefined symbol '${symbol}' used in a menu file."
done
fi
echo
echo "Checking kconfig symbols in rule files ..."
symbols_all="$(<${PTXDIST_TEMPDIR}/SYMBOLS_ALL)"
symbols_all="${symbols_all//$'\n'/ }"
exec {filefd}< <(ptxd_make_world_lint_makefiles)
while read file <&${filefd}; do
ptxd_make_world_lint_symbols_make "${file}"
done < "${ptx_dgen_rulesfiles_make}"
exec {filefd}<&-
echo
}
export -f ptxd_make_world_lint_symbols
PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} symbols"
ptxd_make_world_lint_macros_make() {
local sedfd
# - drop comments
# - split before '$(' to match multiple macros in one line
# - skip any '$$(call ...'
# - match '$(call macro_name,...)'
exec {sedfd}< <(sed -e '/^#/d' -e 's/\(\$\?\$(\)/\n\1/g' "${1}" | \
sed -n -e '/\$\$(call/d' -e 's/.*\$(call \([^,]*\),.*/\1/p' | sort -u)
while read macro <&${sedfd}; do
if ! [[ " ${variables_all} " =~ " ${macro} " ]]; then
ptxd_lint_error "Undefined macro '${macro}' used in '$(ptxd_print_path "${1}")'."
fi
done
exec {sedfd}<&-
}
export -f ptxd_make_world_lint_macros_make
ptxd_make_world_lint_macros() {
local macro variables_all
echo "Checking macros in rule files ..."
if [ ! -e "${PTXDIST_TEMPDIR}/VARIABLES_ALL" ]; then
echo "Your 'make' version is too old for this check!"
echo
return
fi
variables_all="$(<${PTXDIST_TEMPDIR}/VARIABLES_ALL)"
exec {filefd}< <(ptxd_make_world_lint_makefiles)
while read file <&${filefd}; do
ptxd_make_world_lint_macros_make "${file}"
done < "${ptx_dgen_rulesfiles_make}"
exec {filefd}<&-
echo
}
export -f ptxd_make_world_lint_macros
PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} macros"
ptxd_make_world_lint_version() {
local pkg
echo "Checking for packages without version ..."
for pkg in ${ptx_missing_version_pkgs}; do
ptxd_lint_error "Package '${pkg}' has no version."
done
echo
}
export -f ptxd_make_world_lint_version
PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} version"
ptxd_make_world_lint_autogen() {
local dir fd file need_autogen
echo "Checking for missing autogen.sh ..."
if [ -z "$(type -t diffstat)" ]; then
echo "'diffstat' not found, skipping checks for missing autogen.sh"
echo
return
fi
for dir in ${ptx_patch_dir_all}; do
need_autogen=
exec {fd}< <(find "${dir}" -type f ! -name autogen.sh ! -name series)
while read file <&${fd}; do
# Check for configure.ac, Makefile.am and similar files. They
# indicate that autogen.sh is needed. But not if Makefile.in is
# found as well. That means that autoreconf is broken.
if diffstat "${file}" | grep -q '\(configure.\(ac\|in\)\|\(GNUm\|m\|M\)ake.*\.am\)' &&
! diffstat "${file}" | grep -q '\(GNUm\|m\|M\)ake.*\.in'; then
need_autogen=1
break
fi
done < "${ptx_dgen_rulesfiles_make}"
exec {fd}<&-
if [ -n "${need_autogen}" -a ! -e "${dir}/autogen.sh" ]; then
ptxd_lint_error "'$(ptxd_print_path "${file}")' touches files that require autoreconf" \
"but '$(ptxd_print_path "${dir}/autogen.sh") does not exist."
fi
done
echo
}
export -f ptxd_make_world_lint_autogen
PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} autogen"
ptxd_make_world_lint_credits() {
local filefd file
echo "Checking for obsolete 'See CREDITS for details about who has contributed to this project.' comment ..."
exec {filefd}< <(ptxd_make_world_lint_makefiles)
while read file <&${filefd}; do
if grep -q "See CREDITS for details about who has contributed to this project\." "${file}"; then
ptxd_lint_error "'$(ptxd_print_path "${file}")' contains obsolete 'CREDITS' comment."
fi
done < "${ptx_dgen_rulesfiles_make}"
exec {filefd}<&-
}
export -f ptxd_make_world_lint_credits
PTXDIST_LINT_COMMANDS="${PTXDIST_LINT_COMMANDS} credits"
ptxd_make_world_lint() {
local command
for command in ${PTXDIST_LINT_COMMANDS}; do
ptxd_make_world_lint_${command}
done
}
export -f ptxd_make_world_lint
|
