urshd: fix error handling in write

The broken error handling had the effect that no command was ever
executed on the target, with only a message "Unable to write: Success"
in the syslog.

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/urshd.c b/src/urshd.c
index 5391774..c7c6dd2 100644
--- a/src/urshd.c
+++ b/src/urshd.c
@@ -189,7 +189,7 @@ error(const char *fmt, ...)
 	vsnprintf(bp, sizeof(buf) - 1, fmt, ap);
 	va_end(ap);
 
-	if (write(2, buf, strlen(buf)) != 0) {
+	if (write(2, buf, strlen(buf)) < 0) {
 		fatal("error: write: %m");
 	}
 }
@@ -265,7 +265,7 @@ stderr_parent(int sock, int pype, int pid)
 				FD_CLR(pype, &readfrom);
 				guys--;
 			} else {
-				if (write(sock, buf, cc) != 0) {
+				if (write(sock, buf, cc) < 0) {
 					fatal("stderr_parent: %m");
 				}
 			}
@@ -342,7 +342,7 @@ doit(struct sockaddr_in6 *fromp)
 		exit(1);
 	}
 
-	if (write(2, "\0", 1) != 0) {
+	if (write(2, "\0", 1) < 0) {
 		fatal("Unable to write: %m");
 	}
 	sent_null = 1;