summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLucas Stach <l.stach@pengutronix.de>2020-11-20 21:17:15 +0100
committerLucas Stach <l.stach@pengutronix.de>2021-07-21 22:27:09 +0200
commitd4612a10b4c3ca74ec7344080639dfb945442cbf (patch)
tree546997fc05a9cadc8b22e13cf14abbde16df3804
parente94ba8c37302a223fc352e1a939d7855fe36048e (diff)
downloadlinux-d4612a10b4c3ca74ec7344080639dfb945442cbf.tar.gz
linux-d4612a10b4c3ca74ec7344080639dfb945442cbf.tar.xz
drm/bridge: samsung-dsim: fix HFP/HBP/HSA disable modes
The bits in the DSI mode_flags specify that HFP/HBP/HSA should be disabled/ignored by the controller. This is the same polarity as the bits in the DSIM control register where a set bit instructs the controller to ignore the blanking area, so the inversion in the current code is wrong. Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
-rw-r--r--drivers/gpu/drm/bridge/samsung-dsim.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 42b49546dd00..4f9c54d5cf7a 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -665,11 +665,11 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi)
reg |= DSIM_AUTO_MODE;
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSE)
reg |= DSIM_HSE_MODE;
- if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HFP))
+ if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HFP))
reg |= DSIM_HFP_MODE;
- if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HBP))
+ if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HBP))
reg |= DSIM_HBP_MODE;
- if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSA))
+ if ((dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSA))
reg |= DSIM_HSA_MODE;
}