diff options
| author | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2015-05-04 17:59:30 +0200 |
|---|---|---|
| committer | Thiago Santos <thiagoss@osg.samsung.com> | 2015-05-05 13:54:08 -0300 |
| commit | ca100d117cc5d3c9ed49a28cb1d7696ca50f42f8 (patch) | |
| tree | e749bbb442d7c2fae89e049c7f0e55ea1be5c5e9 /sys | |
| parent | 9d85e23c3d960724a551e057cf412989174ee875 (diff) | |
| download | gst-plugins-base-ca100d117cc5d3c9ed49a28cb1d7696ca50f42f8.tar.gz gst-plugins-base-ca100d117cc5d3c9ed49a28cb1d7696ca50f42f8.tar.xz | |
xvimagesink: fix navigation event leak when early returning
Create the event *after* the early return check so it's not leaked.
https://bugzilla.gnome.org/show_bug.cgi?id=748903
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/xvimage/xvimagesink.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c index 611254597..e8752d32b 100644 --- a/sys/xvimage/xvimagesink.c +++ b/sys/xvimage/xvimagesink.c @@ -1137,8 +1137,6 @@ gst_xvimagesink_navigation_send_event (GstNavigation * navigation, gdouble x, y, xscale = 1.0, yscale = 1.0; GstXWindow *xwindow; - event = gst_event_new_navigation (structure); - /* We take the flow_lock while we look at the window */ g_mutex_lock (&xvimagesink->flow_lock); @@ -1183,6 +1181,7 @@ gst_xvimagesink_navigation_send_event (GstNavigation * navigation, (gdouble) y * yscale, NULL); } + event = gst_event_new_navigation (structure); gst_event_ref (event); handled = gst_pad_send_event (peer, event); gst_object_unref (peer); |